This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Update subxt to read constants from metadata at runtime#1
Merged
athei merged 7 commits intoathei:masterfrom Apr 4, 2022
ascjones:aj/runtime-metadata-constants
Merged
Update subxt to read constants from metadata at runtime#1athei merged 7 commits intoathei:masterfrom ascjones:aj/runtime-metadata-constants
athei merged 7 commits intoathei:masterfrom
ascjones:aj/runtime-metadata-constants
Conversation
Owner
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the constant
let max_weight = api.constants().system().block_weights().unwrap();is defined statically from the metadata used in the codegen. So it can obviously differ from the actual value defined in the target node (and they do differ between e.g.substrate-contracts-nodeandcanvas-parachain. See paritytech/subxt#493.This PR updates
subxttomasterwhich now includes paritytech/subxt#494 which uses the metadata fetched from the node at runtime for the constant values.