Connection Request validation using Pydantic #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These follow provisioning spec v1.0. https://sdx-docs.readthedocs.io/en/latest/specs/provisioning-api-1.0.html
We do not care for Python 3.8 anymore, so we can safely drop this backward-compatibility library now.
These connection request files are based on Service Provisioning Data Model Specification 1.0, so they should be V1. https://sdx-docs.readthedocs.io/en/latest/specs/provisioning-api-1.0.html Perhaps the older requests could be renamed V0?
Used `python -m json.tool <input> <output>`.
Pull Request Test Coverage Report for Build 14041006767Details
💛 - Coveralls |
"any".title() returns "Any" etc, which is not necessary
This could validate both v1 style and v0 style requests
Those fields are: - ingress_port - egress_port - bandwidth_required - latency_required - start_time - end_time
The idea is that we should be able to replace the old style models.port.Port with the pydantic connection_request.Port.
EmailStr is enough for email validation
Contributor
Author
|
I think this is ready for a round of review. |
This was referenced Mar 24, 2025
PEP 585 made this a thing since Python 3.9. We no longer need to import the typing module.
This seems to make mypy 1.11.2 is happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #148.