Updates #25
Open
Updates #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakejohns
commented
Sep 17, 2023
jakejohns
commented
- Support psr/log 1, 2, or 3
- Support php8 (phpunit was locked to 7)
- Get rid of deprecation warning for dynamic property creation
phpunit.xml.dist
Outdated
| </whitelist> | ||
| </filter> | ||
| <?xml version="1.0"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="phpunit.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> |
Contributor
There was a problem hiding this comment.
This conflicts with the allowed versions in the Composer configuration, 7 and 9.
The local schema file can be used instead:
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~7.0", | ||
| "phpunit/phpunit": "~7.0 || ~9.0", |
Contributor
There was a problem hiding this comment.
Contributor
Author
|
@froschdesign I believe addressed your points here: anyone have any other thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.