Merged
Conversation
aminya
added
CI
dependencies
DeeDeeG
approved these changes
Aug 22, 2020
Member
There was a problem hiding this comment.
Bumping this in CI is good.
The patch level bump in script/ is probably unnecessary and introduces some code churn, but it shouldn't hurt either.
(Off-topic: I'd similarly prefer we would use a modern Node version in CI, but I guess that doesn't matter. I've tested very thoroughly showing that the build works with Node as old as Node v10.12.0. It doesn't matter much, as far as I can tell, just that I'd like to ensure our scripts aren't behaving weird due to bugs that have been fixed in Node months or even more than a year ago.) (Of course we can't use Node newer than 12.16 due to the babel thing.)
Closed
Member
Author
|
Upstreamed atom#21212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This updates npm to 6.14.8.
Related: atom-community/apm#9
Verification
The CI passes. npm versions are Node version agnostic, so it will work on Node version without changing the behavior.
Drawbacks
none
Release Notes