Update hard-coded GitHub URLs to be dynamic#129
Merged
Conversation
aminya
requested changes
Sep 5, 2020
aminya
force-pushed
the
update-hardcoded-urls
branch
2 times, most recently
from
8927b97 to
1165db0
Compare
Set the following environment variables to override the defaults: REPO_OWNER (default: 'atom') MAIN_REPO (default: 'atom') NIGHLTY_RELEASE_REPO (default: 'atom-nightly-releases') Co-Authored-By: DeeDeeG <DeeDeeG@users.noreply.github.com>
Co-Authored-By: DeeDeeG <DeeDeeG@users.noreply.github.com>
This reverts commit 5a366f3.
aminya
force-pushed
the
update-hardcoded-urls
branch
from
ba6b7d1 to
123d331
Compare
DeeDeeG
commented
Sep 16, 2020
aminya
force-pushed
the
update-hardcoded-urls
branch
from
2a4573d to
03ee9bb
Compare
aminya
force-pushed
the
update-hardcoded-urls
branch
from
03ee9bb to
40898dd
Compare
DeeDeeG
commented
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue or RFC Endorsed by Atom's Maintainers
Closes #83
Description of the Change
Replace various hard-coded URLs throughout the project with dynamic ones. Allows certain features to work with respect to forks, not strictly pointing at the upstream repository.
Set the following environment variables to override the defaults:
REPO_OWNER(default:atom)MAIN_REPO(default:atom)NIGHLTY_RELEASE_REPO(default:atom-nightly-releases)Alternate Designs
None.
Possible Drawbacks
None anticipated. The original values are there as defaults.
Verification Process
CI should pass.
Release Notes
N/A