CI: Really skip uploading artifacts to S3#133
Merged
Conversation
On the "release-branch-build.yml" pipeline, in the "IsSignedZipBranch" condition, we were not passing the re-mapped env variables. This patch fixes the `env:` block to send the re-mapped env vars, as was intended. This fixes an oversight in the previous PR.
Member
Author
|
This is working. I'm happy to merge it some time soon, but take a look if you want @aminya. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#1 (comment), follow-up to: #66, which was re-worked and landed as #99.
Description of the Change
Fix a spot where we missed using the re-mapped S3 and PackageCloud env vars.
(For the condition where
IsSignedZipBranchis true, we were still using the un-re-mapped variables. That would cause them to always be set to not-very-useful$(VAR_NAME_HERE)values. That oversight defeated our skipping mechanism. This patch makes skipping uploads to S3 and PackageCloud work properly again.)Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
See this passing CI run to confirm that it worked: https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=738&view=logs&j=fc7b8a14-4c68-54ee-1e90-04bf630ba360&t=9ad4a9bf-2116-54e4-db45-9da1e971fb4f
Release Notes
N/A