performance: add more CSS containment to text-editor#236
Merged
Conversation
Member
Author
|
Could you test this? @UziTech @lierdakil The binaries will be downloadable from the CI page: https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=984&view=results |
This adds more [CSS containment](https://drafts.csswg.org/css-contain/#contain-property) to text-editor CSS classes. This results in performance improvements by giving the hint to the browser that the size/paint/layout of these elements does not affect other elements around them. The CSS containment for each class is added selectively by testing all the functionalities.
bf631a6 to
65eae9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds more CSS containment to tree-view CSS classes. This results in performance improvements by giving the hint to the browser that the size/paint/layout of these elements does not affect other elements around them.
I have added the CSS containment for each class selectively by testing all the functionalities. As you see, these do not change the functionality.
Benefits
Improves the performance and responsiveness of the text editor. It has improved scrolling performance. The datatips and decorations are rendered faster than before.
The reason is that the browser will not need to recalculate the styles on clicks, scrolling, drag-drop, during the loading, etc.
Quoting CSS specifications
Here I opened the src/text-editor.js and I waited for 15s:


After this PR
Before this PR


Verifications
I have tested all the functionalities including:
This is in addition to all of the tests passing.
Release Notes