Merged
Conversation
This script launches cmd and has it launch atom with the passed arguments. The problem is that cmd will not (necessarily) start in the pwd. So, relative paths like `.` and `..` have a different meaning. So we should first convert them to absolute paths with cygpath. Try it yourself. Go to some directory in bash and run `atom .` Rather than opening your current bash pwd, you'll open $HOME because when cmd opens, that's where it will be. Now apply this change and try the same thing. By the way, I only see this problem affecting MSysGit and MSys2. I can't say whether it affects other environments.
Fix #17627 by using awk to portably separate env vars with \0 instead of \n.
Use printf("...%c...", 0) instead of printf("...\0...") to inject \0.
We have defaulted to using npm that installed as part of the script dependancies. This is to increase predictability on what version of npm was used to install atom dependencies
Install using npm installed during installation of script dependencies
Initial fix to `helpers` done by Utkarsh, Spec written by me. Co-authored-by: Utkarsh Gupta <utkarshgupta137@gmail.com>
…ies-redux Fix `git-diff` nested repositories REDUX
* ⬆️ deprecation-cop@4.0.10 * ⬆️ deprecation-cop 4.0.10 * Update package-lock
⬆️ language-php@0.48.1
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.22 to 3.2.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.22...3.2.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 3.1.1. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.1...v3.1.1) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…de-fetch-3.1.1 Bump node-fetch from 2.6.1 to 3.1.1 in /script
Bump nanoid from 3.1.22 to 3.2.0
... and electron-snapshot to the current electron version (v11)
fix/deps: min versions of electron-chromedriver...
⬆️ Pr-changelog@0.3.4
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bump language-ruby to 0.73.0
This version has all the known security patches in v3.x, and is meanwhile the recommended version to use from CommonJS (NodeJS-style) modules, as opposed to ESM. Atom's build and CI scripts are all CommonJS as far as I know, so we should basically stay on node-fetch v2.x. This fixes the currently broken "Bump dependencies" job in Nightly CI. Effectively reverts ad1318e, AKA #23506, albeit with a more up-to-date patch version of node-fetch v2.x.
deps: "downgrade" node-fetch to ^v2.6.7 in script/ (fix "Bump dependencies" job in Nightly CI)
Author
|
I think atom#23322 broke something because of |
This was referenced Feb 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: This was hard reverted