Skip to content

Cache templates#39

Merged
aminya merged 2 commits intomasterfrom
cache_templates
Jul 11, 2020
Merged

Cache templates#39
aminya merged 2 commits intomasterfrom
cache_templates

Conversation

@aminya
Copy link
Copy Markdown
Member

@aminya aminya commented Jul 11, 2020

Description of the Change

This refactors cache steps into a template.

Verification Process

Ran CI with these changes.

Release Notes

N/A

@aminya aminya force-pushed the cache_templates branch from 121c8d7 to b60ba40 Compare July 11, 2020 03:08
@aminya aminya merged commit 320bd33 into master Jul 11, 2020
@DeeDeeG
Copy link
Copy Markdown
Member

DeeDeeG commented Jul 11, 2020

I think the template is OS-aware without the windows|macos|linux parameters, due to the "$(Agent.OS)" part.

I think we can actually factor the parameters out/delete them.

@aminya
Copy link
Copy Markdown
Member Author

aminya commented Jul 11, 2020

Agent.OS gives different strings such as Window_NT depending on the agent that is being used. Here, we want the exact windows string.

@aminya aminya added the CI label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants