Bring to local branch#98
Merged
aminya merged 10 commits intoatom-community:ci-skip-uploadfrom Aug 21, 2020
Merged
Conversation
These env vars are credentials to authenticate to S3. If they're unset, we can't possibly upload to S3. So we shouldn't try to.
We can't authenticate to PackageCloud without an API key, so don't try to.
The bucket is optional, but Atom uses it. So we will check for this too, just in case https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html
So when they are not available they become an empty string https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#runtime-expression-syntax 
This reverts commit b5d6cb9.
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.