About package does not disable cleanly

[Ben3eeE]

Prerequisites

• Can you reproduce the problem in safe mode?
• Are you running the latest version of Atom?
• Did you check the debugging guide?
• Did you check the FAQs on Discuss?
• Are you reporting to the correct repository?
• Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.

Description

Disabling about package has some issues. Application:about command still exists in palette and help menu and executing it opens a weird atom:\about file that causes atom to hang when saving it.

Same issue different package: atom/settings-view#764

Steps to Reproduce

1. Open atom
2. Disable about
3. (optional) Restart atom
4. Run application:about from command palette or help menu.

Expected behavior: Nothing or some default very basic atom/core about to show.

Actual behavior: Weird non existing file opens that causes atom to hang when saving.

Versions

1.6.X
Windows 7.

[winstliu]

This is because the application:about command is registered in Atom core and not About, presumably so that it can be included inside the default Help menu.
https://github.com/atom/atom/blob/5464883c1ecc581ebe698bc2722b0fe51a7ccda5/src/browser/atom-application.coffee#L206

[magicznyleszek]

Maybe instead of fixing the disabling, it would be better to work on performance (so less people would want to disable it). In my current setup timecop shows that about activates in 11ms

[winstliu]

@smutnyleszek Please feel free to help!

[daviwil]

This issue was moved to atom/atom#17914