Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Depend on node-gyp explicitly#730

Merged
nathansobo merged 2 commits intomasterfrom
ns-explicit-node-gyp-dependency
Jul 19, 2017
Merged

Depend on node-gyp explicitly#730
nathansobo merged 2 commits intomasterfrom
ns-explicit-node-gyp-dependency

Conversation

@nathansobo
Copy link
Copy Markdown
Contributor

We're matching the same version that the bundled npm depends on. This will help us ensure that regardless of how npm organizes the directories, we will know how to access the node-gyp binary. The risk is that someone will update npm without updating node-gyp.

Nathan Sobo added 2 commits July 18, 2017 16:15
We're matching the same version that the bundled npm depends on. This
will help us ensure that regardless of how npm organizes the
directories, we will know how to access the node-gyp binary. The risk is
that someone will update npm without updating node-gyp.
@nathansobo nathansobo merged commit f122e85 into master Jul 19, 2017
@nathansobo nathansobo deleted the ns-explicit-node-gyp-dependency branch July 19, 2017 02:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant