This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remove unnecessary node-gyp header install logic#845
Merged
Conversation
added 13 commits
May 11, 2019 23:36
node-gyp already does this for us when `npm install`ing
node-gyp does check for proxies now: https://github.com/nodejs/node-gyp/blob/721eb691cf15556cc2700eda0558d5bad5f84232/lib/install.js#L432
rafeca
approved these changes
Jun 10, 2019
Contributor
rafeca
left a comment
There was a problem hiding this comment.
Nice @50Wliu ! This looks good to me and the less code we have to handle things that other tools can handle for us the better 😄
Merge and publish whenever suits better for you!
This was referenced Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Currently, any time we have a command that does something related to
npm install, we ensure that the Electron header versions are correctly installed by spawning a process to runnode-gyp installwith the correct Electron version, header URL, etc. It turns out thatnode-gypwill actually do this for us automatically as long as you supply the correct arguments to the relevantnpmcommands. Yay!Alternate Designs
None.
Benefits
There's pretty much no node-gyp code in the codebase now -- it's all handled through npm.
Possible Drawbacks
I don't really see any.
Verification Process
All the specs pass, which depend on node-gyp finding and downloading the correct header files.
Applicable Issues
None, but can be seen as a followup to #832
Todo