Stop putting desktop shortcut in automatic updates

[jimgraham]

Windows 7 SP1 x64, Atom 0.159 updating

Steps

• Install Atom
  • desktop shortcut added
• Delete desktop shortcut
• Wait for Atom to be updated
• See "Downloading update" in Help Menu
• _super annoying, not-asked for, desktop shortcut reappears_
• See "Restart and Install Update" in Help Menu

I know you want to do "zero user interaction updates" and be all Squirrel-y etc. but this is very annoying and pollutes my environment.

The update should not install a desktop shortcut. Maybe it should replace an existing shortcut i.e. update the pointer to from old version to new version but only if the shortcut exists. I could see the original installer placing a desktop short cut on the first install.

[winstliu]

I asked about this some time ago, and apparently once Squirrel is fleshed out, if you delete the shortcuts, it won't put them back.

[jimgraham]

@50Wliu is there another open issue that I can 👍 instead of keeping this open ?

[postcasio]

Found this one: Squirrel/Squirrel.Windows#41

[jimgraham]

Closing in favour of the Squirrel issue above.

[jimgraham]

according to @paulcbetts I need to keep this open

@jimgraham You need to file this bug on Atom, they explicitly create shortcuts so they need to manage that explicitly

[kevinsawicki]

@jimgraham Thanks so much for raising this, apologies for the desktop shortcut annoyance.

I just pushed a fix for this. It checks if the desktop shortcut exists and deletes it after telling squirrel to update the start menu and desktop shortcuts.

So it will be recreated (by squirrel) and then immediately deleted by Atom if it was previously deleted. This can be improved upon once squirrel supports separate APIs for desktop and start menu shortcut creation, Squirrel/Squirrel.Windows#167

[jimgraham]

@kevinsawicki Awesome response time! Thanks so much.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!