Atom's package.json should support other npm-style repository formats

[silvenon]

For example, atom-jshint has repository set to sindresorhus/atom-jshint in its package.json, which should be fine, but Atom seems to default to git:// when rendering package links.

[mnquintana]

This looks like an issue with atom-jshint, not so much with Atom – atom-jshint explicitly defines its repo url as git://github.com/sindresorhus/atom-jshint:

Maybe it would be better though if Atom could "catch" this kind of GitHub URL mistake and automatically replace git:// with https://?

[lee-dohm]

For additional context:

• https://discuss.atom.io/t/links-in-preferences-packages-go-to-xcode/14050
• Links in Preferences->Packages Go To Xcode sindresorhus/atom-editorconfig#26

Essentially, the problem is that while there is much in common between Atom's package.json format and npm's package.json format, Atom's package.json does not yet support everything that npm's does. I can't speak to whether it is the intention of the Atom team to make Atom's format completely compatible with npm's either, so I'll mark this as an enhancement for now.

The workaround for now is for package authors to use the HTTPS URL of their GitHub repo's home page as the repository attribute.

[lee-dohm]

I hope you don't mind that I changed the title @silvenon to be more descriptive of the underlying problem. Thanks so much for reporting the issue!

[silvenon]

@mnquintana from which file is that code coming from? Isn't this the package.json from v1.1.3? If indeed there is a git:// protocol in the package.json, then this is not a bug.

I hope you don't mind that I changed the title @silvenon to be more descriptive of the underlying problem.

No problem, whatever helps 😃

[mnquintana]

@silvenon Well this just got weird. I took this screenshot from my installed version of atom-jshint's package.json, and it still shows git:// in the latest version, 1.1.4, even though it doesn't on the package's repo on GitHub. 😕

Try this to reproduce:

1. Install jshint from Settings > Install
2. Go to jshint > Settings > View Code
3. Take a look at that package.json

[silvenon]

Yep, you're right, I got the same. How does that happen? 😃

[mnquintana]

Closing in favor of atom/settings-view#543

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!