This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Merged
Conversation
This can be extended by extensions targetted towards acting on text inside the editor and not contributing any UI
RootView and Editor now have helpers that support binding events to callbacks, binding a callback to all current and future editors, and replacing the selected text via a transforming callback.
This allows extensions to bind a callback to all current and future buffers.
This commit eliminates the custom `snippets` format and instead just uses CSON/JSON.
Previously, we parsed snippet bodies line at a time, then determined tab stops within lines. But this disallows tab stops with placeholder text that spans multiple lines. Now the parser produces a simpler structure that breaks the body into an array of strings and tab stops. Newlines are represented directly as characters within the strings.
Has 2 failing specs... There are still some issue with this code's interaction with the undo system. The tab stops will need to be or destroyed when certain changes are undone or redone.
We're giving up on correctly restoring snippet expansions that occurred in a different EditSession.
There's still a bunch of holes in this. TextMate snippets have features that we don't support yet. But the basic ones should now work.
Instead of in AtomPackage.load
This was referenced May 21, 2024
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.