Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Remove some default packages#1549

Merged
kevinsawicki merged 4 commits intomasterfrom
ks-remove-some-default-packages
Feb 20, 2014
Merged

Remove some default packages#1549
kevinsawicki merged 4 commits intomasterfrom
ks-remove-some-default-packages

Conversation

@kevinsawicki
Copy link
Contributor

Closes #1477
Refs #1537

@nathansobo
Copy link
Contributor

The only one that gives me pause is visual-bell

@kevinsawicki
Copy link
Contributor Author

What about it pauses you?

@nathansobo
Copy link
Contributor

Seems like a nice feature to retain.

On Monday, February 17, 2014, Kevin Sawicki notifications@github.com
wrote:

What about it pauses you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/1549#issuecomment-35308876
.

@kevinsawicki
Copy link
Contributor Author

Yeah, personally I've never used it and @probablycorey suggested removing it in #1477 which is why I removed it.

@nathansobo
Copy link
Contributor

Am I mistaken in my assumption that visual-bell that flashes the screen white when running an erroneous search in find-and-replace?

@nathansobo
Copy link
Contributor

I just confirmed I'm correct about that. I think that's worth keeping but if you really want to remove it I won't make a fuss.

@kevinsawicki
Copy link
Contributor Author

I think we should remove it and see what happens, it makes for a solid package to feature.

kevinsawicki added a commit that referenced this pull request Feb 20, 2014
@kevinsawicki kevinsawicki merged commit e5200d5 into master Feb 20, 2014
@kevinsawicki kevinsawicki deleted the ks-remove-some-default-packages branch February 20, 2014 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove some packages from core build.

2 participants