Allow Title Bar to be Hidden (closes #13249)#21234
Conversation
|
It seems the linter isn't working. Any help would be appreciated! |
|
This closes #13249 |
|
Oh this is so exciting @TheDrawingCoder-Gamer! |
|
It seems that the specs aren't working. Please help with specs so we can hammer this out! |
Run Prettier broke fixtures. Reverting...
|
Please help me unbork this |
|
I'm pretty limited in my knowledge about the backend of Atom, but i'm sure i could find some time soon to learn a bit of it. Might be able to to give you a hand @TheDrawingCoder-Gamer. Is the linter failing and that's it? |
|
No, some more is borked. Some things in the text editor in spec are failing. Run specs, mostly specs are borked |
|
Hi @TheDrawingCoder-Gamer, fellow Atom hackerizer from the community here. I'd like to point out that some tests fail by timing out in the CI environment. They often fail even for "correct" code, and pass when allowed to re-run several times. Are you certain that the specs are truly broken? Maybe they just need a chance to re-run. Also, NSlog builds okay for me on |
|
There are a fair amount of changes here that don't look 100% related to the main purpose of this PR. You can revert them one file at a time by doing the following: (For any version of git): (For git 2.25 or newer): You can list multiple paths/to/files, and/or paths/to/folders after the |
|
I'm using GitHub Desktop and revert commit seems to be working well. I wish I had made more commits or I wouldn't have to be unstaging hunks. |
|
I'm sure some tests are messed up because there are number mismatches, and the like. |
|
I think this would actually pass but there is a timeout |
|
Can I force the check to rerun or does a mod have to |
|
Yeah, it's possible this would pass if re-run. You can set up a (free) Azure DevOps account if you want to run the CI yourself. (I already have an account set up, so I could run it for you on my account, and post a link to the results if that would help, to see if it passes. Would not make this PR show as "passing", though.) DetailsI see there are a couple of timeouts on Windows x64, which isn't really that uncommon at this repo. CI timeouts on genuinely working code tend to happen on Windows x64, or one of the three macOS test runners. (It's a problem that's being looked at and worked on, but the cause isn't obvious, so the solution isn't obvious either.)
I'm pretty sure one of Atom's maintainers would have to do it, for the CI attached to this PR. Anyone can clone your branch and run CI on it from their own Azure DevOps account, though. (That takes a bit of setup time, I'll admit). |
|
I suppose that's fine, as long as it works. (I shouldn't really answer that, since it's the Atom maintainers' repo, so it would be down to their preferences. But looking at past PRs, things like that have been merged.) |
|
Running |
|
I tried this from Windows and nothing I tried worked. I was able to fix it from a Linux computer, though. I can open a pull request to your branch over at your fork of Atom if you'd like? |
|
Yes please I am getting frustrated over this file |
spec/helpers/words.js: Restore line endings
|
It looks like the changes to that file are resolved now. @TheDrawingCoder-Gamer Sorry about all the frustration. Usually I try to help people learn the git commands (that old saying about "teach the person to fish rather than give them the fish"). Edit/Update: I think I've got this figured out now? The following should have worked, and I'm able to reproduce it reliably working on Windows now: > git checkout c79d2adbe0c8902e87624049982a31fd7e4c3ebe -- spec/helpers/words.js
> git status # This should show that spec/helpers/words.js is modified and ready to be committed
> git diff --staged --stat # This should show spec/helpers/words.js was changed with a large (equal) amount of added/removed lines
> git commit -m "some commit message"OR: > git restore --staged --source=c79d2adbe0c8902e87624049982a31fd7e4c3ebe -- spec/helpers/words.js # Note the "--staged" flag!
> git status # This should show that spec/helpers/words.js is modified and ready to be committed
> git diff --staged --stat # This should show spec/helpers/words.js was changed with a large (equal) amount of added/removed lines
> git commit -m "some commit message" |
|
It is more helpful to learn than be given, but I never knew that this could be unfixable. We're in the home stretch now, and it's probably gonna be included. Thank you for helping with this PR! |
|
https://dev.azure.com/benharless820/benharless820/_build/results?buildId=9&view=results Restore git-repository-spec.js |
|
Linux failed 3 times |
|
@TheDrawingCoder-Gamer The linux failures are unrelated to this PR and we are trying to figure out why its failing atom/apm#900. Thank you for your contribution. Looking forward to review more PR's from you 😄 |
|
How to hidden the title bar? I'm use the 1.53.0 on Windows 10 |
On a Mac, you can go to core > title bar in the settings and edit it from there |
Thank you! on Windows 10 it's OK too But when I hidden the title bar and menu, I cann't show the menu. Now how can I do to use the menu? |
When this setting is enabled, Atom's built-in menu goes away. You can still visit settings by pressing Ctrl + ,. This is meant to be used with something that provides a custom title bar, like this: https://atom.io/packages/title-bar-replacer (I'm sure there are other packages like available as well.) |
title-bar-replacer is very good! thank u |
7 participants
Requirements for Adding, Changing, or Removing a Feature
Issue or RFC Endorsed by Atom's Maintainers
See #13249
Description of the Change
This opens the already available option on macOS to hide the title bar to Windows and Linux. This requires little work and makes it much easier for packages like atom-title-bar-replacer to work. Note only the hidden and native options are exposed.
Alternate Designs
Editing the source code like atom-title-bar-replacer does. This is undesirable as source editing is dangerous and unstable
Possible Drawbacks
The title bar being hidden might make it hard to close the window.
Verification Process
Toggling the title bar on and off seems to cause no issues.
Release Notes
Allows Hiding of Title Bar on all platforms