Update the "welcome" package's package-lock.json (eliminates some warnings in CI)

[DeeDeeG]

Requirements for Contributing a Bug Fix (from template, click to expand):

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
• The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

There were warnings about cache keys changing in the macOS Tests packages-2 job. (Follow-up to #21884).

Description of the Change

I ran npm install (and apm install -- the result was the same) in the packages/welcome folder, and committed the updated lockfile.

No actual dependencies or dependency versions were updated. Just the "requires" fields and some "optional" fields.

(I'm not sure why every "requires" field had been recorded with absolute version numbers... Modern npm and apm should record the actual semver range for each dependency in each package's respective package.json file... Not the absolute, resolved/final version number.)

Alternate Designs

This lockfile was updated when installing its test runner dependencies during script/test. I tried running apm ci instead of apm install to install these dependencies. That would be more consistent and slightly faster. The problem with that is, some of the packages with test runner dependencies do not ship lockfiles. And you can't run npm ci/apm ci without a lockfile already being present.

This alternate design would be doable if we went through all of the packages in Atom core that have test runners specified in their package.json files, and made sure each of these packages ship a package-lock.json file. However, committing a lockfile to a repo is a subjective choice with some tradeoffs. There are times when not having a lockfile is legitimate. So I would rather not enforce every core package have a lockfile just to get rid of these warnings in CI.

Possible Drawbacks

None.

Verification Process

I did a CI run; the warnings about The given cache key has changed . . . went away.
https://dev.azure.com/DeeDeeG/b/_build/results?buildId=1019

Release Notes

N/A

[DeeDeeG]

@sadick254 this eliminates the warning messages in CI I introduced in #21884.

---

Explanation: I figured out that one of the packages had an outdated format of data in package-lock.json. Now that that's updated (no dependencies or versions changed, just the way it's recorded) the file doesn't change after an apm install, and the cache ID is stable, so the warnings go away.

[sadick254]

Thank you @DeeDeeG for the quick follow up PR. This looks great. 👍