Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

script/test: Add another timeout message to retry for#21898

Merged
sadick254 merged 1 commit intoatom:masterfrom
DeeDeeG:retry-for-additional-timeout-message
Jan 28, 2021
Merged

script/test: Add another timeout message to retry for#21898
sadick254 merged 1 commit intoatom:masterfrom
DeeDeeG:retry-for-additional-timeout-message

Conversation

@DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Jan 27, 2021

Requirements for Contributing a Bug Fix (from template, click to expand):

Identify the Bug

Timeouts in CI.

Example timeout: CI Link

Details

In the Windows Tests x64_Renderer_Test2 job:

Workspace
  .checkoutHeadRevision()
    it Workspace .checkoutHeadRevision() reverts to the version of its file checked into the project repository
      Error: Timed out waiting on anonymous condition
        at conditionPromise (D:\a\1\s\spec\async-spec-helpers.js:20:13)
        at jasmine.Spec.<anonymous> (D:\a\1\s\spec\workspace-spec.js:3931:7)

Follow-up to: #21295

Description of the Change

Retry any test if the message "Error: Timed out waiting on [ . . . ]" is encountered.

(I've so far only seen this as "Error: Timed out waiting on anonymous condition", but I left it more general in case it applies to named conditions as well (whatever those would be).)

Alternate Designs

None.

Possible Drawbacks

Makes these flaky tests stand out a bit less in the results.

Verification Process

I suppose to properly verify this, one would have to run this through CI a bunch of times and try to notice whether there are fewer timeouts making the CI fail. I don't see why it wouldn't work, though.

Release Notes

N/A

We should retry when encountering "Error: Timed out waiting on",
seen in the wild as "Error: Timed out waiting on anonymous condition".
Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@sadick254 sadick254 merged commit 83a883e into atom:master Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants