This repository was archived by the owner on Mar 3, 2023. It is now read-only.
script/test: Add another timeout message to retry for#21898
Merged
sadick254 merged 1 commit intoatom:masterfrom Jan 28, 2021
Merged
script/test: Add another timeout message to retry for#21898sadick254 merged 1 commit intoatom:masterfrom
sadick254 merged 1 commit intoatom:masterfrom
Conversation
We should retry when encountering "Error: Timed out waiting on", seen in the wild as "Error: Timed out waiting on anonymous condition".
aminya
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix (from template, click to expand):
Identify the Bug
Timeouts in CI.
Example timeout: CI Link
Details
In the
Windows Tests x64_Renderer_Test2job:Follow-up to: #21295
Description of the Change
Retry any test if the message "Error: Timed out waiting on [ . . . ]" is encountered.
(I've so far only seen this as "Error: Timed out waiting on anonymous condition", but I left it more general in case it applies to named conditions as well (whatever those would be).)
Alternate Designs
None.
Possible Drawbacks
Makes these flaky tests stand out a bit less in the results.
Verification Process
I suppose to properly verify this, one would have to run this through CI a bunch of times and try to notice whether there are fewer timeouts making the CI fail. I don't see why it wouldn't work, though.
Release Notes
N/A