Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Create a global option to follow symlinks in project-wide search#4689

Merged
benogle merged 1 commit intoatom:masterfrom
ebayer:follow-symlinks
Dec 20, 2014
Merged

Create a global option to follow symlinks in project-wide search#4689
benogle merged 1 commit intoatom:masterfrom
ebayer:follow-symlinks

Conversation

@ebayer
Copy link

@ebayer ebayer commented Dec 18, 2014

@lee-dohm
Copy link
Contributor

If this is only affecting the behavior of the find-and-replace package, it should be under find-and-replace not core. Which consequently also implies that this change should be on the find-and-replace package.

@ebayer
Copy link
Author

ebayer commented Dec 18, 2014

It effects scandal, so I assumed it effects anything that uses scandal.

@mehcode
Copy link
Contributor

mehcode commented Dec 18, 2014

@lee-dohm If I understand this correctly It would also affect Ctrl+P, etc.

@ebayer
Copy link
Author

ebayer commented Dec 18, 2014

@mehcode Yes, it also affects that, the following screenshot is taken when root folder consists of only symlinks.

@ebayer
Copy link
Author

ebayer commented Dec 18, 2014

screenshot 2014-12-18 20 08 59

benogle added a commit that referenced this pull request Dec 20, 2014
Create a global option to follow symlinks in project-wide search
@benogle benogle merged commit e0741d2 into atom:master Dec 20, 2014
@benogle
Copy link
Contributor

benogle commented Dec 20, 2014

Legit. ❤️

@benogle
Copy link
Contributor

benogle commented Dec 20, 2014

This will be out in the next version. The followSymlinks option will default to false for now. We dont want to change behavior and cause extra pain or issue creation going into the holidays. I plan to default enable it once we fix some duplication issues in atom/fuzzy-finder#67 (and likely fnr).

@ebayer ebayer deleted the follow-symlinks branch December 22, 2014 02:41
This was referenced Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find and Replace doesn't across directory symlinks

4 participants