Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

API to Notify render processes when updates are available#900

Merged
mcolyer merged 7 commits intomasterfrom
mc-release-notes
Oct 1, 2013
Merged

API to Notify render processes when updates are available#900
mcolyer merged 7 commits intomasterfrom
mc-release-notes

Conversation

@mcolyer
Copy link
Contributor

@mcolyer mcolyer commented Sep 27, 2013

This is a proposal for how we can communicate from the browser process to the render process that a new update is available. This was my best guess about how to do it but I'm definitely open to suggestions.

Summary

  • Sparkle triggers 'ready-for-update-on-quit' in the browser process
  • The browser process forwards that event as a command to all of it's render processes.
  • Each render process receives that event as a command and triggers it on a rootView.
  • Packages that would like to know when an update is available listen to window:update-available

Note this branch also adds updateAvailable to loadSettings which is passed to AtomWindow (which is available in a browser process by calling atom.getLoadSettings().updateAvailable).

This enables atom-archive/release-notes#1

@kevinsawicki
Copy link
Contributor

Looks good to me, 👍

@probablycorey
Copy link

Instead of keeping state in atom.getLoadSettings().updateAvailable I think it might be simpler to always use the 'window:update-available' IPC event. We can trigger it after the window is created. This will limit the places where the update state is stored.

@mcolyer
Copy link
Contributor Author

mcolyer commented Sep 30, 2013

@probablycorey how about now?

mcolyer added a commit that referenced this pull request Oct 1, 2013
API to Notify render processes when updates are available
@mcolyer mcolyer merged commit 42e2545 into master Oct 1, 2013
@mcolyer mcolyer deleted the mc-release-notes branch October 1, 2013 23:41
This was referenced Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants