This repository was archived by the owner on Mar 3, 2023. It is now read-only.
API to Notify render processes when updates are available#900
Merged
API to Notify render processes when updates are available#900
Conversation
Contributor
|
Looks good to me, 👍 |
|
Instead of keeping state in |
Contributor
Author
|
@probablycorey how about now? |
mcolyer
added a commit
that referenced
this pull request
Oct 1, 2013
API to Notify render processes when updates are available
This was referenced Mar 26, 2021
This was referenced Feb 18, 2022
This was referenced Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for how we can communicate from the browser process to the render process that a new update is available. This was my best guess about how to do it but I'm definitely open to suggestions.
Summary
window:update-availableNote this branch also adds
updateAvailableto loadSettings which is passed to AtomWindow (which is available in a browser process by callingatom.getLoadSettings().updateAvailable).This enables atom-archive/release-notes#1