Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Opinionated language packages?#1

Open
lee-dohm wants to merge 1 commit intomasterfrom
opinionated-language-packages
Open

Opinionated language packages?#1
lee-dohm wants to merge 1 commit intomasterfrom
opinionated-language-packages

Conversation

@lee-dohm
Copy link
Contributor

@lee-dohm lee-dohm commented Apr 5, 2016

@joshaber
Copy link

joshaber commented Apr 5, 2016

I'm inclined to say we shouldn't be opinionated except where syntax itself dictates.

Text editors are personal for programmers which is why we love Atom.

@lee-dohm
Copy link
Contributor Author

lee-dohm commented Apr 5, 2016

So would you support reverting the setting in language-python that defaults to four spaces?

@joshaber
Copy link

joshaber commented Apr 5, 2016

I think so, but I'm really curious to hear what others think.

@Alhadis
Copy link

Alhadis commented Apr 5, 2016

Just out of curiosity, how are tabs baneful in Python? They seem like the most logical choice of indentation style for a whitespace-significant language.

@lee-dohm
Copy link
Contributor Author

lee-dohm commented Apr 6, 2016

@Alhadis You'd have to ask Guido Van Rossum and the other authors of the PEP8. The question here isn't "tabs vs spaces" in any case.

@lee-dohm
Copy link
Contributor Author

lee-dohm commented Apr 6, 2016

I agree that we shouldn't be opinionated, we should only support syntactic requirements. Personally, I feel like Python is a special exception because it is:

  1. A style guide written by the author of the language
  2. Intended to be followed in all cases even if not enforced by the language itself

Similarly, I would support updating the language-go package to have defaults in line with the gofmt tool (even though the gofmt tool itself makes such an effort unnecessary).

@Alhadis
Copy link

Alhadis commented Apr 6, 2016

I've written Python using hard tabs before. Unlike YAML, spaces aren't a syntactic requirement of Python. Therefore, there's no logical reason a user MUST use spaces as their indent style when authoring Python code. Having the editor unexpectedly change indentation style runs counter to user expectations.

Exceptions shouldn't be made on a "users should" basis, because that introduces a slippery slope. Look at PHP's PEP guidelines. Note how they also mandate the use of 4-spaces instead of tabs. Since that's what the community recommendation is, should Atom be obliged to honour that, too? What about Rust, whose maintainers WANT you to use spaces instead of tabs? All of these pose questions that are difficult to answer short of admittedly arbitrary logic like "that's what the community's agreed on".

In other words, it's a Pandora's Box. Best leave it closed.

@atom atom locked and limited conversation to collaborators Apr 6, 2016
@lee-dohm
Copy link
Contributor Author

lee-dohm commented Apr 6, 2016

@Alhadis Thank you very much for your feedback. We have heard from you on this multiple times and we know your stance. It is time to allow the Atom team to discuss what we are comfortable with supporting and why.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants