Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix up wrap around icon#611

Merged
benogle merged 3 commits intomasterfrom
bo-fix-wrap-icon
Dec 3, 2015
Merged

Fix up wrap around icon#611
benogle merged 3 commits intomasterfrom
bo-fix-wrap-icon

Conversation

@benogle
Copy link
Contributor

@benogle benogle commented Dec 3, 2015

This is an extension on #572. There were a couple issues:

  • The icon was only shown when the find view was open
  • The icon could not be centered vertically over the editor in CSS because it was a child of the find view
  • The icon was centered horizontally over the fnr panel, not the editor, so it didnt make sense with splits
  • The colors didnt work well with some theme combinations

Looks like this now:

screen shot 2015-12-03 at 3 29 13 pm

cc @mrodalgaard

Otherwise it will only show when there the find view is shown
* Center the icon in the editor
* Make better use of variables
benogle added a commit that referenced this pull request Dec 3, 2015
@benogle benogle merged commit 2114fe9 into master Dec 3, 2015
@benogle
Copy link
Contributor Author

benogle commented Dec 3, 2015

Travis is soooo sloooow.

@benogle benogle deleted the bo-fix-wrap-icon branch December 3, 2015 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant