This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Prefix relatived paths with ./ to avoid .gitignore quirk
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing the path to a file that is ignored via a pattern like `**.log`, libgit2 only recognizes the path as ignored if it starts with `./`. So we change the `relativize` method to include a leading `./` so that these kind of patterns work correctly on relativized paths. Co-Authored-By: Antonio Scandurra <as-cii@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍐'd with @as-cii
After the upgrade of
libgit2in #91,.gitignorepatterns such as**.logonly match relative paths that start with./. We callrelativizein Atom before asking whether a path is ignored, but prior to this PR, the relative paths returned by this method do not include a./prefix, leading to an incorrect displaying of ignored status in the tree view in atom/tree-view#1317.This PR changes the relativize method to include the
./prefix, and we also add a regression test for atom/tree-view#1317.