Select next diff when the current diff is fully committed?

[joshaber]

1. Click on a diff.
2. Commit it.
3. Diff closes as expected.

For me, at least, in most cases I then select the next diff and commit it. Should we do that automatically? /cc @simurai

[simurai]

With "next diff", do you mean after committing, select the next/top file in the list and show the diff pane?

Hmmm.. hard to say. We could try it and see how it feels. It might be annoying having to close the diff pane if you aren't ready for the next commit and you wanna edit some more.

[joshaber]

With "next diff", do you mean after committing, select the next/top file in the list and show the diff pane?

Right.

It might be annoying having to close the diff pane if you aren't ready for the next commit and you wanna edit some more.

Yeah, though for me if I'm not committing I'm likely to hit escape which would close all the things.

[simurai]

I'm not committing I'm likely to hit escape which would close all the things.

Sold!

Another thing.. should it auto-stage all files when opening the git panel? Like it does in GitHub Desktop? Or at least add a stage all checkbox at the top. I more likely commit everything, but some maybe like to make smaller commits. Different issue tough.

[joshaber]

should it auto-stage all files when opening the git panel? Like it does in GitHub Desktop?

The thing about Desktop is that selecting/unselecting lines doesn't actually stage them. We only stage as part of committing. Staging all lines by default would be expensive for performance.

Or at least add a stage all checkbox at the top.

Yeah, I think we should definitely do that 👍

[kuychaco]

This has been handled