Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
0f1fbf8
use new builder methods
vanessayuenn Nov 15, 2018
c348812
found some mistakes in the old test logic
vanessayuenn Nov 15, 2018
4b69eaf
more new builders yay 🔧
vanessayuenn Nov 15, 2018
3e81788
cleanup unused code
vanessayuenn Nov 15, 2018
63ac1ee
clean up unused imports and :fire: `.only`
vanessayuenn Nov 15, 2018
f6b697f
lint
vanessayuenn Nov 15, 2018
285b935
don't need `markRange()` anymore
vanessayuenn Nov 15, 2018
beb1db4
onto patch test
vanessayuenn Nov 15, 2018
d42a4ee
build fixture!
vanessayuenn Nov 15, 2018
0690ec8
more builder tingss
vanessayuenn Nov 15, 2018
c75efcf
chore(package): update node-fetch to version 2.3.0
greenkeeper[bot] Nov 13, 2018
48c8bfb
chore(package): update lockfile package-lock.json
greenkeeper[bot] Nov 13, 2018
147ec74
Update Enzyme and its React 16 adapter
smashwilson Nov 14, 2018
c857bb7
Require Enzyme's React adapter correctly
smashwilson Nov 14, 2018
96e7702
Enzyme's shallow renderer can't track render props
smashwilson Nov 14, 2018
fe33a3d
Fix error where getFilePath is not a function on a CommitPreviewItem
Nov 14, 2018
094ef45
props only work if you pass them to child components
Nov 14, 2018
3a6f38c
:art: Make UI more consistent
Nov 14, 2018
7a429f0
we don't need to test for no stinkin tooltips
Nov 15, 2018
41672b6
Explicitly only render Undo Discard button if ChangedFileItem
kuychaco Nov 15, 2018
2edac5a
Explicitly only render Undo Discard button if ChangedFileItem
kuychaco Nov 15, 2018
f465b65
Add `itemType` prop types for :shirt:
kuychaco Nov 15, 2018
e4dfdfc
Make basename bold in FilePatchHeaderView
kuychaco Nov 15, 2018
b37857b
Fix tests to include itemType
kuychaco Nov 15, 2018
009db81
Update docs/react-component-atlas.md
kuychaco Nov 15, 2018
4238f98
Update docs/react-component-atlas.md
kuychaco Nov 15, 2018
5afc6d6
:world: CommitPreviewItem is beneath RootController, not GitHubTabItem
smashwilson Nov 15, 2018
e05cd54
Use an object spread for that data why not
smashwilson Nov 15, 2018
7de5c5e
Pass a Decoration's className to the created DOM element
smashwilson Nov 15, 2018
efbecd7
Set and style a more specific CSS class for control blocks
smashwilson Nov 15, 2018
03fe1a6
File.modes constants for well-known file modes
smashwilson Nov 15, 2018
9b94c2e
Use File mode constants where possible
smashwilson Nov 15, 2018
ec5081a
Add Release Notes section
kuychaco Nov 15, 2018
9617073
Go into more detail on why that opener is necessary
smashwilson Nov 15, 2018
3a526e7
tweak symlink changes styles
Nov 15, 2018
8fa79df
executable mode change styling tweaks
Nov 15, 2018
a3051cd
:fire: unused cache key for stagedChangesSinceParentCommit
kuychaco Nov 15, 2018
44d2971
Use `path.sep` to join dirname and basename
smashwilson Nov 16, 2018
10b661c
Avoid double "\\ No newline at end of file"
smashwilson Nov 16, 2018
7d552e9
Skip filesystem events with no path
smashwilson Nov 16, 2018
ad8c198
Remove unnecessary <Fragment>
smashwilson Nov 16, 2018
6e96997
Wait for new unstaged patch to arrive
smashwilson Nov 16, 2018
c449012
Adapt the expected path separator to the current platform
smashwilson Nov 16, 2018
5339435
Default itemType to avoid the PropTypes warning
smashwilson Nov 16, 2018
21a0b03
Workspace item watcher only cares about active items
kuychaco Nov 16, 2018
399e3f3
:fire: props that aren't used in `CommitPreviewItem`
kuychaco Nov 16, 2018
7fc9da2
:fire: mysterious handleClick prop in MultiFilePatchController
kuychaco Nov 16, 2018
699199a
Invalidate `stagedChanges` key when undoing last commit or head moves
kuychaco Nov 16, 2018
2387ce9
:fire: useEditorAutoHeight since we are now using a single editor
kuychaco Nov 16, 2018
80d7bfc
Actually we want autoHeight set to false on AtomTextEditor
kuychaco Nov 16, 2018
1e002b0
:fire: .only
kuychaco Nov 16, 2018
aecae83
📝 comment for `intersectRows`
vanessayuenn Nov 16, 2018
8fd8002
:fire: unnecessary button class name
Nov 16, 2018
0efcdc9
compare multifilepatches with toString()
vanessayuenn Nov 16, 2018
764194a
change variable name to make the logic more clear
vanessayuenn Nov 16, 2018
27c2187
Activate the commit preview on cmd-left from the button
smashwilson Nov 16, 2018
6bce2da
MultiFilePatchView prop rename
smashwilson Nov 16, 2018
8a66b1b
Pass surface callback through MultiFilePatchController
smashwilson Nov 16, 2018
e015a02
Bring the keymap up to date
smashwilson Nov 16, 2018
9227020
ChangedFileController to control surfacing behavior for ChangedFileItems
smashwilson Nov 16, 2018
262ce92
CommitPreviewController to interpret surface as surfaceToCommitPreview
smashwilson Nov 16, 2018
bab2948
Render a ChangedFileController within the container
smashwilson Nov 16, 2018
e224548
Destroy the atomEnv
smashwilson Nov 16, 2018
5f91ebe
Render a CommitPreviewController within CommitPreviewContainer
smashwilson Nov 16, 2018
e5e241b
Add missing PropTypes to the CommitPreviewItem
smashwilson Nov 16, 2018
a17ce73
Unconditional CommitPreviewItem activation for github:dive binding
smashwilson Nov 16, 2018
b5e5ec6
Imperatively select the commit preview button
smashwilson Nov 16, 2018
5b430ea
GitTabView commit preview focusing
smashwilson Nov 16, 2018
93344f7
Forward surfaceToCommitPreviewButton to the GitTabController
smashwilson Nov 16, 2018
b1671c1
Method to surface and focus the commit preview button
smashwilson Nov 16, 2018
d055bbc
:fire: debugger
smashwilson Nov 16, 2018
1a52239
Revert "compare multifilepatches with toString()"
kuychaco Nov 16, 2018
9c41d5d
package-lock updates
kuychaco Nov 16, 2018
86ab7c5
Add logic to `getNextSelectionRange` so that selection remains at bot…
kuychaco Nov 16, 2018
9335fd0
Test that bottom-most line is selected after staging bottom-most line
kuychaco Nov 16, 2018
d4b7427
Add more comments to explain logic in `getNextSelectionRange`
kuychaco Nov 16, 2018
74b75c9
WIP Fix one thing, break another =/. Fix marker for patches w/ no hunks
kuychaco Nov 17, 2018
8f43d5f
Add test for marker range for a patch with no hunks
kuychaco Nov 17, 2018
08fdcc7
Ensure that marker range for no-hunk patch is not affected by hunks a…
kuychaco Nov 17, 2018
3226db3
Throw error if too many markers found (to help with debugging)
kuychaco Nov 17, 2018
22e9cfa
:fire: .only
kuychaco Nov 17, 2018
cb0ab10
Revert "Throw error if too many markers found (to help with debugging)"
smashwilson Nov 19, 2018
88a6593
add missing props to CommitPreviewItem tests
Nov 19, 2018
8170e84
fix integration tests for file patch
Nov 19, 2018
44f9e51
add test for `surfaceToCommitPreviewButton` in `RootController`
Nov 19, 2018
b756246
test that getFileMode returns the correct file mode for symlinks
Nov 19, 2018
f6d2b5e
test file mode for executable files in git-strategies test
Nov 20, 2018
bf4e62a
test that repository.updateCommitMessageAfterFileSystemChange handles…
Nov 20, 2018
6cd1f4d
maybe make windows filemode happy?
Nov 20, 2018
ddc5ebe
istanbul ignore test-only code
Nov 20, 2018
c2f9b91
Test that getPanesWithStalePendingFilePatchItem ignores CommitPreview…
kuychaco Nov 20, 2018
2d6f7a8
:shirt:
Nov 20, 2018
bfe50b0
fix misaligned line numbers in file mode changes
Nov 20, 2018
e5eaa28
Check that `getFileMode` works for untracked symlink files
kuychaco Nov 20, 2018
f27ba01
Fix `undoLastDiscardFromCoreUndo` for keyboard users
kuychaco Nov 20, 2018
b87f9f4
Fix test for undoing last discard from `core:undo`
kuychaco Nov 20, 2018
858943b
Restyle mode changes
simurai Nov 20, 2018
978ef15
just press the button
vanessayuenn Nov 16, 2018
d28d9aa
Merge branch 'master' into vy/use-new-builders
vanessayuenn Nov 21, 2018
a56ad3b
add empty method to hunkbuilder
vanessayuenn Nov 21, 2018
1a2b80f
finish up patch test
vanessayuenn Nov 21, 2018
1355b7f
remove unused helper method
vanessayuenn Nov 21, 2018
53ea203
🔥 `.only`
vanessayuenn Nov 21, 2018
2add2b3
this test doesn't work :/
vanessayuenn Nov 22, 2018
ddc6514
Merge branch 'master' into vy/use-new-builders
kuychaco Dec 6, 2018
d9bb980
Merge branch 'master' into vy/use-new-builders
vanessayuenn Dec 17, 2018
35eb71d
Merge branch 'master' into vy/use-new-builders
vanessayuenn Jan 31, 2019
a067c40
put the original test back in
vanessayuenn Jan 31, 2019
a02b76d
fix the startrange test
vanessayuenn Jan 31, 2019
aedcd40
:fire: `.only`
vanessayuenn Jan 31, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/builder/patch.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ class HunkBuilder {
this.newRowCount = null;

this.sectionHeading = "don't care";
this.explicitlyEmpty = false;

this.hunkStartPoint = this.layeredBuffer.getInsertionPoint();
this.regions = [];
Expand Down Expand Up @@ -267,8 +268,13 @@ class HunkBuilder {
return this;
}

empty() {
this.explicitlyEmpty = true;
return this;
}

build() {
if (this.regions.length === 0) {
if (this.regions.length === 0 && !this.explicitlyEmpty) {
this.unchanged('0000').added('0001').deleted('0002').unchanged('0003');
}

Expand Down
Loading