Rewrite autobind calls as class properties

lib/atom/gutter.js

@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import {Disposable} from 'event-kit';
 
-import {autobind, extractProps} from '../helpers';
+import {extractProps} from '../helpers';
 import {RefHolderPropType} from '../prop-types';
 import {TextEditorContext} from './atom-text-editor';
 import RefHolder from '../models/ref-holder';
@@ -32,7 +32,7 @@ class BareGutter extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'observeEditor', 'forceUpdate');
+    this.forceUpdate = this.forceUpdate.bind(this);
 
     this.state = {
       gutter: null,
@@ -67,7 +67,7 @@ class BareGutter extends React.Component {
     return null;
   }
 
-  observeEditor(editor) {
+  observeEditor = editor => {
     this.setState((prevState, props) => {
       if (prevState.gutter !== null) {
         prevState.gutter.destroy();

lib/atom/keystroke.js

@@ -3,7 +3,6 @@ import PropTypes from 'prop-types';
 import {humanizeKeystroke} from 'underscore-plus';
 import {Disposable} from 'event-kit';
 
-import {autobind} from '../helpers';
 import {RefHolderPropType} from '../prop-types';
 
 export default class Keystroke extends React.Component {
@@ -17,7 +16,6 @@ export default class Keystroke extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'didChangeTarget');
 
     this.sub = new Disposable();
     this.state = {keybinding: null};
@@ -56,7 +54,7 @@ export default class Keystroke extends React.Component {
     }
   }
 
-  didChangeTarget(target) {
+  didChangeTarget = target => {
     const [keybinding] = this.props.keymaps.findKeyBindings({
       command: this.props.command,
       target,

lib/atom/marker-layer.js

@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import {CompositeDisposable, Disposable} from 'event-kit';
 
-import {autobind, extractProps} from '../helpers';
+import {extractProps} from '../helpers';
 import RefHolder from '../models/ref-holder';
 import {TextEditorContext} from './atom-text-editor';
 import {DecorableContext} from './marker';
@@ -34,8 +34,6 @@ class BareMarkerLayer extends React.Component {
   constructor(props) {
     super(props);
 
-    autobind(this, 'createLayer');
-
     this.subs = new CompositeDisposable();
     this.layerSub = new Disposable();
 
@@ -90,7 +88,7 @@ class BareMarkerLayer extends React.Component {
     this.subs.add(this.state.editorHolder.observe(this.createLayer));
   }
 
-  createLayer() {
+  createLayer = () => {
     this.subs.remove(this.layerSub);
     this.layerSub.dispose();
 

lib/atom/marker.js

@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import {CompositeDisposable, Disposable} from 'event-kit';
 
-import {autobind, extractProps} from '../helpers';
+import {extractProps} from '../helpers';
 import {RefHolderPropType, RangePropType} from '../prop-types';
 import RefHolder from '../models/ref-holder';
 import {TextEditorContext} from './atom-text-editor';
@@ -42,8 +42,6 @@ class BareMarker extends React.Component {
   constructor(props) {
     super(props);
 
-    autobind(this, 'createMarker', 'didChange');
-
     this.markerSubs = new CompositeDisposable();
     this.subs = new CompositeDisposable();
 
@@ -94,7 +92,7 @@ class BareMarker extends React.Component {
     this.subs.add(this.props.markableHolder.observe(this.createMarker));
   }
 
-  createMarker() {
+  createMarker = () => {
     this.markerSubs.dispose();
     this.markerSubs = new CompositeDisposable();
     this.subs.add(this.markerSubs);
@@ -126,7 +124,7 @@ class BareMarker extends React.Component {
     this.markerHolder.map(marker => marker.setBufferRange(this.props.bufferRange));
   }
 
-  didChange(event) {
+  didChange = event => {
     const reversed = this.markerHolder.map(marker => marker.isReversed()).getOr(false);
 
     const oldBufferStartPosition = reversed ? event.oldHeadBufferPosition : event.oldTailBufferPosition;

lib/atom/pane-item.js

@@ -6,7 +6,7 @@ import {CompositeDisposable} from 'event-kit';
 import URIPattern, {nonURIMatch} from './uri-pattern';
 import RefHolder from '../models/ref-holder';
 import StubItem from '../items/stub-item';
-import {createItem, autobind} from '../helpers';
+import {createItem} from '../helpers';
 
 /**
  * PaneItem registers an opener with the current Atom workspace as long as this component is mounted. The opener will
@@ -39,7 +39,6 @@ export default class PaneItem extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'opener');
 
     const uriPattern = new URIPattern(this.props.uriPattern);
     const currentlyOpen = this.props.workspace.getPaneItems()
@@ -99,7 +98,7 @@ export default class PaneItem extends React.Component {
     this.subs.dispose();
   }
 
-  opener(uri) {
+  opener = uri => {
     const m = this.state.uriPattern.matches(uri);
     if (!m.ok()) {
       return undefined;

lib/containers/changed-file-container.js

@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import yubikiri from 'yubikiri';
 
-import {autobind} from '../helpers';
 import ObserveModel from '../views/observe-model';
 import LoadingView from '../views/loading-view';
 import ChangedFileController from '../controllers/changed-file-controller';
@@ -24,12 +23,7 @@ export default class ChangedFileContainer extends React.Component {
     surfaceFileAtPath: PropTypes.func.isRequired,
   }
 
-  constructor(props) {
-    super(props);
-    autobind(this, 'fetchData', 'renderWithData');
-  }
-
-  fetchData(repository) {
+  fetchData = repository => {
     const staged = this.props.stagingStatus === 'staged';
 
     return yubikiri({
@@ -47,7 +41,7 @@ export default class ChangedFileContainer extends React.Component {
     );
   }
 
-  renderWithData(data) {
+  renderWithData = data => {
     if (this.props.repository.isLoading() || data === null) {
       return <LoadingView />;
     }

lib/containers/current-pull-request-container.js

@@ -3,7 +3,6 @@ import PropTypes from 'prop-types';
 import {QueryRenderer, graphql} from 'react-relay';
 import {Disposable} from 'event-kit';
 
-import {autobind} from '../helpers';
 import {RemotePropType, RemoteSetPropType, BranchSetPropType, OperationStateObserverPropType} from '../prop-types';
 import IssueishListController, {BareIssueishListController} from '../controllers/issueish-list-controller';
 import CreatePullRequestTile from '../views/create-pull-request-tile';
@@ -39,7 +38,6 @@ export default class CurrentPullRequestContainer extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'renderQueryResult', 'renderEmptyTile');
 
     this.sub = new Disposable();
   }
@@ -98,7 +96,7 @@ export default class CurrentPullRequestContainer extends React.Component {
     return <BareIssueishListController isLoading={false} {...this.controllerProps()} />;
   }
 
-  renderQueryResult({error, props, retry}) {
+  renderQueryResult = ({error, props, retry}) => {
     if (retry) {
       this.sub.dispose();
       this.sub = this.props.remoteOperationObserver.onDidComplete(retry);
@@ -140,7 +138,7 @@ export default class CurrentPullRequestContainer extends React.Component {
     );
   }
 
-  renderEmptyTile() {
+  renderEmptyTile = () => {
     return (
       <CreatePullRequestTile
         repository={this.props.repository}

lib/containers/git-tab-container.js

@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import yubikiri from 'yubikiri';
 
-import {autobind} from '../helpers';
 import {nullCommit} from '../models/commit';
 import {nullBranch} from '../models/branch';
 import ObserveModel from '../views/observe-model';
@@ -28,13 +27,7 @@ export default class GitTabContainer extends React.Component {
     repository: PropTypes.object.isRequired,
   }
 
-  constructor(props) {
-    super(props);
-
-    autobind(this, 'fetchData');
-  }
-
-  fetchData(repository) {
+  fetchData = repository => {
     return yubikiri({
       lastCommit: repository.getLastCommit(),
       recentCommits: repository.getRecentCommits({max: 10}),

lib/containers/github-tab-container.js

@@ -3,7 +3,6 @@ import PropTypes from 'prop-types';
 import yubikiri from 'yubikiri';
 
 import {GithubLoginModelPropType, RefHolderPropType} from '../prop-types';
-import {autobind} from '../helpers';
 import OperationStateObserver, {PUSH, PULL, FETCH} from '../models/operation-state-observer';
 import GitHubTabController from '../controllers/github-tab-controller';
 import ObserveModel from '../views/observe-model';
@@ -20,7 +19,6 @@ export default class GitHubTabContainer extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'fetchRepositoryData', 'renderRepositoryData');
 
     this.state = {};
   }
@@ -36,7 +34,7 @@ export default class GitHubTabContainer extends React.Component {
     return null;
   }
 
-  fetchRepositoryData(repository) {
+  fetchRepositoryData = repository => {
     return yubikiri({
       workingDirectory: repository.getWorkingDirectoryPath(),
       allRemotes: repository.getRemotes(),
@@ -59,7 +57,7 @@ export default class GitHubTabContainer extends React.Component {
     );
   }
 
-  renderRepositoryData(data) {
+  renderRepositoryData = data => {
     if (!data || this.props.repository.isLoading()) {
       return (
         <GitHubTabController

lib/containers/issueish-detail-container.js

@@ -12,7 +12,6 @@ import QueryErrorView from '../views/query-error-view';
 import ObserveModel from '../views/observe-model';
 import IssueishDetailController from '../controllers/issueish-detail-controller';
 import RelayEnvironment from '../views/relay-environment';
-import {autobind} from '../helpers';
 
 export default class IssueishDetailContainer extends React.Component {
   static propTypes = {
@@ -30,17 +29,7 @@ export default class IssueishDetailContainer extends React.Component {
     workspace: PropTypes.object.isRequired,
   }
 
-  constructor(props) {
-    super(props);
-    autobind(this,
-      'fetchToken', 'renderWithToken',
-      'fetchRepositoryData', 'renderWithRepositoryData',
-      'renderWithResult',
-      'handleLogin', 'handleLogout',
-    );
-  }
-
-  fetchToken(loginModel) {
+  fetchToken = loginModel => {
     return yubikiri({
       token: loginModel.getToken(this.props.host),
     });
@@ -54,7 +43,7 @@ export default class IssueishDetailContainer extends React.Component {
     );
   }
 
-  fetchRepositoryData(repository) {
+  fetchRepositoryData = repository => {
     return yubikiri({
       branches: repository.getBranches(),
       remotes: repository.getRemotes(),
@@ -66,7 +55,7 @@ export default class IssueishDetailContainer extends React.Component {
     });
   }
 
-  renderWithToken(tokenData) {
+  renderWithToken = tokenData => {
     if (!tokenData) {
       return <LoadingView />;
     }
@@ -92,7 +81,7 @@ export default class IssueishDetailContainer extends React.Component {
     );
   }
 
-  renderWithRepositoryData(repoData, token) {
+  renderWithRepositoryData = (repoData, token) => {
     if (!repoData) {
       return <LoadingView />;
     }
@@ -142,7 +131,7 @@ export default class IssueishDetailContainer extends React.Component {
     );
   }
 
-  renderWithResult({error, props, retry}, repoData) {
+  renderWithResult = ({error, props, retry}, repoData) => {
     if (error) {
       return (
         <QueryErrorView
@@ -177,11 +166,7 @@ export default class IssueishDetailContainer extends React.Component {
     );
   }
 
-  handleLogin(token) {
-    return this.props.loginModel.setToken(this.props.host, token);
-  }
+  handleLogin = token => this.props.loginModel.setToken(this.props.host, token)
 
-  handleLogout() {
-    return this.props.loginModel.removeToken(this.props.host);
-  }
+  handleLogout = () => this.props.loginModel.removeToken(this.props.host)
 }

lib/containers/issueish-search-container.js

@@ -3,7 +3,6 @@ import PropTypes from 'prop-types';
 import {QueryRenderer, graphql} from 'react-relay';
 import {Disposable} from 'event-kit';
 
-import {autobind} from '../helpers';
 import {SearchPropType, OperationStateObserverPropType} from '../prop-types';
 import IssueishListController, {BareIssueishListController} from '../controllers/issueish-list-controller';
 import RelayNetworkLayerManager from '../relay-network-layer-manager';
@@ -26,7 +25,6 @@ export default class IssueishSearchContainer extends React.Component {
 
   constructor(props) {
     super(props);
-    autobind(this, 'renderQueryResult');
 
     this.sub = new Disposable();
   }
@@ -68,7 +66,7 @@ export default class IssueishSearchContainer extends React.Component {
     );
   }
 
-  renderQueryResult({error, props, retry}) {
+  renderQueryResult = ({error, props, retry}) => {
     if (retry) {
       this.sub.dispose();
       this.sub = this.props.remoteOperationObserver.onDidComplete(retry);