This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 409
Adjust diff indentation #298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@as-cii Do you think it's ok to add an extra space after the
|
Contributor
|
This looks great @simurai! Thanks for the quick fix! As for showing an extra space, I think it might be okay although I wonder if it would be perceived as if it was part of the change. Maybe we give pluses and minuses a different column? |
Contributor
Author
Contributor
|
I'll let @nathansobo and @kuychaco chime in on this, but I think we can keep the space and remove it later in case it's ambiguous. |
Contributor
|
👍 on preferring clean formatting to perfect accuracy. |
Contributor
|
Agreed on keeping the space 👍 . Looks nicer, and I think it's intuitive enough that it is not part of the change. |
This was referenced Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Closes #294
/cc @as-cii