Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Oct 29, 2016

Closes #294

Before After
screen shot 2016-10-29 at 10 17 32 am screen shot 2016-10-29 at 10 15 52 am

/cc @as-cii

@simurai
Copy link
Contributor Author

simurai commented Oct 29, 2016

@as-cii Do you think it's ok to add an extra space after the +/-? I think it increases readability and it makes it look less like the +/- is part of the following text.

+Removing 👉 + Removing

@as-cii
Copy link
Contributor

as-cii commented Oct 29, 2016

This looks great @simurai! Thanks for the quick fix!

As for showing an extra space, I think it might be okay although I wonder if it would be perceived as if it was part of the change. Maybe we give pluses and minuses a different column?

@simurai
Copy link
Contributor Author

simurai commented Nov 1, 2016

No space Extra column
screen shot 2016-11-01 at 6 16 53 pm screen shot 2016-11-01 at 6 18 22 pm

Hmm.. extra column makes it more clear but also more clutter. I think I still like with space the best, but happy to remove it, if it's a concern.

@as-cii
Copy link
Contributor

as-cii commented Nov 1, 2016

I'll let @nathansobo and @kuychaco chime in on this, but I think we can keep the space and remove it later in case it's ambiguous.

@nathansobo
Copy link
Contributor

nathansobo commented Nov 1, 2016

👍 on preferring clean formatting to perfect accuracy.

@kuychaco
Copy link
Contributor

kuychaco commented Nov 1, 2016

Agreed on keeping the space 👍 . Looks nicer, and I think it's intuitive enough that it is not part of the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants