This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Highlight hunk title #299
Merged
Highlight hunk title #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simurai
commented
Oct 29, 2016
lib/views/hunk-view.js
Outdated
|
|
||
| render () { | ||
| const hunkSelectedClass = this.props.isSelected ? 'is-selected' : '' | ||
| const hunkModeClass = !this.props.headLine ? 'is-hunkMode' : '' |
Contributor
Author
There was a problem hiding this comment.
@kuychaco Is this a good way to check what the current mode is?
"If there is no headLine prop, it must be in hunk mode."
Contributor
|
@simurai this looks great! Definitely helps with discovery. I made a slight modification around identifying selection mode. If there's nothing else you'd like to add, I say |
Contributor
Author
Thanks.. ya, looks much better. ok, let's 🚢 . |
This was referenced Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not that easy to discover that you can click the title to select an entire hunk. This PR adds some hover and selected styles.