Rename CSS classes from git -> github #372
Conversation
smashwilson
left a comment
smashwilson
left a comment
There was a problem hiding this comment.
Looking good 👍
I tracked down the CI failure, but I'd ❤️ to get this merged quickly so that we can deal with conflicts in our other branches sooner rather than later.
Isn't it fun when we all work on sweeping changes that touch the entire package at once 😉
lib/views/commit-view.js
Outdated
| onclick={this.commit.bind(this)} | ||
| disabled={!this.isCommitButtonEnabled()}>{this.commitButtonText()}</button> | ||
| <div ref="remainingCharacters" className={`git-CommitView-remaining-characters ${remainingCharsClassName}`}> | ||
| <div ref="remainingCharacters" className={`github-CommitView-remaining-characters ${remainingCharsClassName}`}> |
There was a problem hiding this comment.
It looks like this line is just over the maximum line length for eslint:
> eslint --max-warnings 0 test lib
/Users/travis/build/atom/github/lib/views/commit-view.js
112:1 warning Line 112 exceeds the maximum line length of 120 max-len
Yeah, sorry. 😇 Seeing you talk about renaming the keybindings reminded me to also rename the CSS classes. Something I was thinking.. if we want to separate the styling more from the logic, we could use a convention to never find elements by its CSS class. Instead use a separate class with a |
This PR renames the namespace of all the CSS classes from
gittogithub. So that it matches the package name.Conflicts
This PR probably conflicts with:
CI fail
Unrelated?
ESLint found too many warnings (maximum: 0).