This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fixed <%-- --%> based comment end rule
#106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<%--` based commenting is broken because the `'end'` rule was indented twice too much Fixed by removing the two 'space' indents for `'end'` and `'name'`
|
I cannot see info about |
Author
|
I don't have any experience with XML |
Seems `<%--` `--%>` is not part of the offical standard and it doesn't work currently so might as well just remove it competely
Open
This was referenced Oct 3, 2025
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<%--based commenting is broken because the'end'rule was indented twice too muchFixed by removing the two extra 'space' indents for
'end'and'name'Broken comment:
Fixed comment:
Found this bug while looking at vscode extensions:
