This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Conversation
added 11 commits
March 12, 2017 12:16
These methods will always block on the most recent `importPathsPromise`, so that we can call `load` as soon as possible when booting Atom.
Contributor
Author
|
After integrating this into Atom and thinking about it more, I have realized that making the interface asynchronous doesn't improve caching throughput significantly and, as a result, is not worth the added complexity. There are other ways in which we can improve performance and that I will address in a couple of forthcoming pull requests:
After the above improvements land, I think we should go on and start moving other I/O and CPU work into the snapshot, such as setting each package's config schema and loading their settings files. Then, we can address packages preloading and fix other low hanging fruits, like waiting synchronously on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request rewrites
LessCachein JavaScript and exposes a new Promise-based API that won't block the event loop when reading from or writing to the cache.Please, note that we will still parse less files and read their imports synchronously: this is somewhat unfortunate, but adapting the
ImportManagerfromless.jsto allow us to determine imports is non-trivial and, even though some work has already been done in #11, for now it just feels simpler to access only the cache asynchronously and rely on #12 to minimize other I/O./cc: @nathansobo