Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@zeke
Copy link
Contributor

@zeke zeke commented Sep 8, 2017

Successor to #66

@zeke
Copy link
Contributor Author

zeke commented Sep 8, 2017

This looks good to go. I just realized I'm not an owner of the npm package. Pinging folks to see if I can get added.

@zeke zeke merged commit ff73d23 into master Sep 8, 2017
@zeke zeke deleted the support-node-4 branch September 8, 2017 15:31
@zeke
Copy link
Contributor Author

zeke commented Sep 8, 2017

@nathansobo hooked me up as an owner.

I bumped the major to be on the safe side.

$ np major
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using npm
 ✔ Running tests
 ✔ Bumping version using npm
 ✔ Publishing package
 ✔ Pushing tags

 oniguruma 7.0.0 published 🎉

Thanks for making this change, @elingerojo. 👍

@elingerojo
Copy link
Contributor

@ashleygwilliams
@zeke

Thank you both for setting the ball rolling again. I was stalled for this Node 4 support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants