This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Allow hunspell implementation to be used on OSX #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
force-pushed
the
mb-allow-hunspell-on-mac
branch
4 times, most recently
from
5664228 to
b1fc200
Compare
4 tasks
maxbrunsfeld
force-pushed
the
mb-allow-hunspell-on-mac
branch
from
b1fc200 to
cd2f7e3
Compare
maxbrunsfeld
pushed a commit
that referenced
this pull request
Jan 6, 2016
Allow hunspell implementation to be used on OSX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Hunspell spell-checker implementation is built on Linux and Windows, but not on OSX. On Windows, users can choose to use Hunspell at runtime by setting the
SPELLCHECKER_PREFER_HUNSPELLenvironment variable.Now, when installing the library on Mac, you can choose to compile it with Hunspell support by running this:
If you do that, then you can choose Hunspell at runtime via the environment variable, similar to the windows version.
I chose not to include hunspell in the binary by default, since most Mac users won't need it, and it lengthens the build time and the binary size. I just needed so I could work on the Hunspell implementation on my Mac.
/cc @paulcbetts @kevinsawicki