This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Updating command.target to be an Object instead of String#173
Open
madhuhc wants to merge 1 commit intoatom:masterfrom
Open
Updating command.target to be an Object instead of String#173madhuhc wants to merge 1 commit intoatom:masterfrom
madhuhc wants to merge 1 commit intoatom:masterfrom
Conversation
Probable fix for the below issue atom/atom#15639 We are accessing nodeName and className from target so it should ideally be an object. Added safe-check and initialize target to be an {}
UziTech
added a commit
to UziTech/notifications
that referenced
this pull request
Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probable fix for the below issue
atom/atom#15639
We are accessing nodeName and className from target so it should ideally be an object. Added safe-check and initialize target to be an {}
Requirements
Not a pro in coffeescript, need a simple check and default assignment to target as {}
Description of the Change
Target should be an Object not the String
Alternate Designs
Better way to handle the issue
Benefits
atom/atom#15639
Possible Drawbacks
Not pro in coffeescript syntax
Applicable Issues
atom/atom#15639