Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

RFE: remove pusher.com dependency#50

Open
nonameentername wants to merge 5 commits intoatom:masterfrom
nonameentername:private-solution
Open

RFE: remove pusher.com dependency#50
nonameentername wants to merge 5 commits intoatom:masterfrom
nonameentername:private-solution

Conversation

@nonameentername
Copy link
Copy Markdown

Implemented #35

@jasonrudolph
Copy link
Copy Markdown
Contributor

👋 Hi @nonameentername: I just wanted to drop a note to acknowledge this pull request and say thanks for taking this on. Based on the discussion in #35, it seems like several people could be happy to try out this pull request. 😄

We're heads down on a handful of other priorities at the moment, so it's unlikely that we'll be able to give this pull request the thorough review it deserves in the near term. However, if people are able to make use of these changes by checking out your branch, then I think that's awesome. ✌️

@nonameentername nonameentername force-pushed the private-solution branch 2 times, most recently from ece53fc to d19d22e Compare July 30, 2018 01:58
@twcurrie
Copy link
Copy Markdown

What's the status on this???? This looks awesome.

@nonameentername
Copy link
Copy Markdown
Author

Thanks! I'll resolve conflicts so it can be merged.

@rriemann
Copy link
Copy Markdown

Dear @jasonrudolph ,

it is a bit over a year since the pull request was proposed. I hope that you have some time in the near future to consider it for inclusion.

From a data protection compliance perspective, pusher is yet another data processor, which introduces again more work on contracts and data protection policies. Also here, an on-prem solution would allow for an easier adoption of teletype.

Best,
Robert

@adamlwgriffiths
Copy link
Copy Markdown

The teletype and teletype-client repositories merge cleanly.
The teletype-server seems to have only minor conflicts.

@adamlwgriffiths
Copy link
Copy Markdown

I've forked this PR and performed a merge with the latest develop.
https://github.com/adamlwgriffiths/teletype-server/tree/private-solution

However, I don't have the means to test it at the moment.
Feedback would be appreciated, I can add collaborator permissions if someone would like to pitch in.

RFE: remove pusher.com dependency - Merged
@adamlwgriffiths
Copy link
Copy Markdown

@nonameentername merged my changes so this PR should be up to date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants