This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Don't try to delete entries which no longer exist#1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Do not attempt to delete files/folders that no longer exist. This can happen when:
Alternate Designs
None.
Benefits
Since the file no longer exists, we don't have to try deleting it! And hence no error will be shown.
Possible Drawbacks
This won't keep track of renames.
Applicable Issues
Couldn't find any.
Additional info: the existing spec to make sure error notifications were displayed was actually using this behavior to trigger the notification. I have rewritten it to spy on the actual trash method and return false from there, tricking Tree View into thinking that the operation failed.