Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Symlink entry kind#111

Merged
smashwilson merged 9 commits intomasterfrom
symlinks
Feb 6, 2018
Merged

Symlink entry kind#111
smashwilson merged 9 commits intomasterfrom
symlinks

Conversation

@smashwilson
Copy link
Copy Markdown
Contributor

@smashwilson smashwilson commented Feb 6, 2018

Add an EntryKind to represent actions performed on symlinks. Identify symlinks from uv_fs_lstat() and uv_fs_scandir() results and report them as a distinct kind in reported events.

Part of #19.

@smashwilson
Copy link
Copy Markdown
Contributor Author

Grr. inotify only includes a boolean IN_ISDIR flag on events. While the only two entry kinds were ENTRY_FILE and ENTRY_DIRECTORY, that was enough to classify events properly, but it isn't enough to identify ENTRY_SYMLINK.

I'm going to introduce a RecentFileCache into the Linux handler and use it to balance the cost of doing an lstat() on every path with the cost of storing a bunch of previous results. That's complex enough that I probably should work on an actual Linux machine to do it, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant