Add node-pre-gyp to publish binaries#135
Conversation
985816b to
8505e82
Compare
8505e82 to
56a3be2
Compare
|
I prefer prebuild for this because it can auto-upload binaries to the tag's GitHub release, no S3 bucket needed. Any chance node-pre-gyp can do the same? |
|
Ah, didn’t know about preload. I agree it’s nicer to not add the S3 dep. |
|
Turns out there's a nifty The only thing required for this new update to work is an envvar in the CI |
| "author": "GitHub", | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "aws-sdk": "2.220.1", |
There was a problem hiding this comment.
Looks like this may have snuck in from the previous S3 based solution?
There was a problem hiding this comment.
Ah, possible. I can take it out and see if things still work?
There was a problem hiding this comment.
Yea that was a prereq for s3, should be removable.
This PR adds
node-pre-gyp(https://github.com/mapbox/node-pre-gyp) to handle binary packaging and publishing. I testednpm installandnpm run publishwith my AWS creds for theatom-watcher-testS3 bucket I created and it all worked as expected.A couple things will need to be handled by the maintainers of this package:
[ci-publish]Alternate Designs
What
node-pre-gypdoes could be manually handled, but it seemsnode-pre-gypis pretty well established and worked for me with minimal configuration.Benefits
Uploading built binaries will save time for everyone wanting to install this package.
Possible Drawbacks
If a prebuilt binary doesn't exist, the tool will fallback and build locally, so there's little drawback to this addition.
Applicable Issues
Closes #134
/cc @smashwilson