This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Update node-pre-gyp to the latest version 🚀#166
Merged
smashwilson merged 1 commit intomasterfrom Aug 12, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.11.0 of node-pre-gyp was just published.
The version 0.11.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of node-pre-gyp.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 12 commits.
d606a69add latest node v10 versions7785e06bump to v0.11.0674fda7Merge pull request #405 from jschlight/napi-improvementse0e1f43Merge pull request #408 from addaleax/fix-install-cb-twice5eb112cFix issue withcloseevent always being emittedb5081affix case of Note2f6c0e1Code tweaks, documentation2e0118cBug fix in napi.validate_package_json68ac4ddCode cleanup.502651dCode cleanup.2ae0e8eCode cleanup.154ca45Initial commit.See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴