Conversation
smashwilson
left a comment
There was a problem hiding this comment.
Our linter isn't happy with this. We're using standard.js for the JavaScript side of things, so you should be able to run npm run format:js and get most of the way there.
Once that's green i'm 💯 on merging this, this would be super handy!
lib/cli.js
Outdated
| } | ||
|
|
||
| function start(dirs, verbose) { | ||
| const options = { recursive: true }; |
There was a problem hiding this comment.
Were you meaning to make this another user-controlled flag?
There was a problem hiding this comment.
No, I think that recursive is probably the wanted option here. Do you think I should use an option here?
|
Oh, one more thing - would you mind adding a section to the README about this as well? |
|
I've fixed the lint (I've used prettier instead of standard the first time), and I've added a paragraph in the README. I think it's ready to be merged if the CI is Okay. |
|
🎉 |
Description of the Change
The CLI can be used like this:
Alternate Designs
I've tried to do something simple, with no external dependencies. An alternative would be to copy chokidar-cli, with more options. But if we want to go in this direction, it'd better to do that outside of this repository, and in a new npm package.
Benefits
It should help for testing @atom/watcher and reporting issues.
Possible Drawbacks
It will be one more file in the npm package, and the script may have to be maintained in the future.
Applicable Issues
N/A