Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix CI + Add Node 12 Support#234

Merged
lkashef merged 10 commits intomasterfrom
1.3.2
May 19, 2020
Merged

Fix CI + Add Node 12 Support#234
lkashef merged 10 commits intomasterfrom
1.3.2

Conversation

@lkashef
Copy link
Copy Markdown
Contributor

@lkashef lkashef commented May 19, 2020 •
edited
Loading

  • Update all CI config files to support node 12
  • Updated xcode version to unblock ci (8.3.3 has been deprecated)
  • Bump nan dependency
  • Run format C++
  • Disabled C++ Lint task for now, due to ~200 warnings-as-errors resulted from the mandatory xcode upgrade

@lkashef lkashef merged commit 3e64d0e into master May 19, 2020
@lkashef lkashef changed the title Add Node 12 Support Fix CI + Add Node 12 Support May 19, 2020
@DeeDeeG DeeDeeG mentioned this pull request Jul 3, 2020
Merged
This was referenced Jul 13, 2020
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lkashef