Issues with New Multi-Wrap Guide

[JosephTLyons]

Prerequisites

• [X ] Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

I'm having some issues with this new version of wrap guide.

I haven't been able to have multiple wrap guides show up successfully yet. If I edit the wrap guide columns array in the config file, as per the instructions, I never see multiple guides (even after reloading Atom to ensure the settings "took"):

This issue occurs whether I'm in safe mode or not.

I have my master (editor) preferred line length set to 100, as thats how I like to code, but I have the PLL in certain language packages set to 80. Packages such as Markdown lang and txt lang are set to 80, as thats how I like to write my documentation. Could this be causing some of the issues? If I delete the values in the wrap guide columns array, I would expect that wrap guide would go back to the way it was and would default to the editor's PLL, unless a language package is loaded that overrides that value, but none of this is working now.

So I can't see to get the new functionality to work (multiple wrap guides) and I can't see to set it up so that it works like it used to (a default PLL that can be overridden by a package's PLL). Is there a way to fix this? Maybe I'm doing something incorrectly? If not, what's the best way to roll back to the last stable version?

Versions

macOS: 10.14.3
Atom : 1.36.0
Electron: 2.0.18
apm 2.1.3

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

[JosephTLyons]

So I was able to return it to the old style by disabling wrap-guide, going through my config file and deleting all the occurrences of the wrap-guide settings for each language, then re-enabling it. So I now have one guide that is dynamic, like it used to be. But I can't seem to get it to work as soon as I add any items to the input box for the columns array in the settings panel.

[rsese]

Thanks for the report! I did run into some trouble when I started editing the setting multiple times but it did seem to work if I:

1. reset the package's settings to "wrap-guide": {} in config.cson
2. enter 80, 100 in the Columns setting

Do things work for you in this case?

I also see that as I adjust the setting, whatever file types I have open seem to have language specific settings created for it e.g. since I was looking at the config.cson, if I changed the Column setting that I edited in step (2) to 80, 100, 120, then this was added to my config:

".coffee.source":
  editor:
    preferredLineLength: 100
  "wrap-guide":
    columns: [
      80
      100
    ]

Then at some point, the Columns setting is no longer editable from the package settings and I need to edit config.cson directly.

[JosephTLyons]

Sorry for the lengthy wait on this. I was in the last few weeks off my CSCI degree and was totally out-of-touch with everything else.

Thanks for the report! I did run into some trouble when I started editing the setting multiple times but it did seem to work if I:

1. reset the package's settings to "wrap-guide": {} in config.cson
2. enter 80, 100 in the Columns setting

Do things work for you in this case?

It does seem that manually setting the settings in the file, as you explained, versus using the columns input in the wrap-guide's preferences, tends to work. I should say that it seems to be working now, but I just made the change not long ago, so I'll have to come back and post an update in a few days to see if this fix works for sure.

I also see that as I adjust the setting, whatever file types I have open seem to have language specific settings created for it e.g. since I was looking at the config.cson, if I changed the Column setting that I edited in step (2) to 80, 100, 120, then this was added to my config:

I also had this same thing occur.

[sigod]

Then at some point, the Columns setting is no longer editable from the package settings and I need to edit config.cson directly.

I'm having the same issue. Tried to edit the package's config and now I see this in config.cson:

"*":
  ...
  welcome:
    showOnStartup: false
  "wrap-guide":
    columns: [
      115
    ]
".rust.source":
  editor:
    preferredLineLength: 1
  "wrap-guide":
    columns: [
      1
    ]
".source.sql":
  editor:
    preferredLineLength: 1
  "wrap-guide":
    columns: [
      1
    ]