Fix ResidualJunctionCompartment not applying stochasticity correctly#473
Merged
Rowanmh merged 2 commits intostochastic_transitionsfrom May 10, 2023
Merged
Fix ResidualJunctionCompartment not applying stochasticity correctly#473Rowanmh merged 2 commits intostochastic_transitionsfrom
Rowanmh merged 2 commits intostochastic_transitionsfrom
Conversation
…with a ">" residual link. - `outflow` wasn't updated with the stochastic outflow_fractions, and - The probabilities need to sum to 1 in a multinomial so we give the residual probability to the residual link - Also checks that net_inflow is an integer and throws an error if it is not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trouble was with a ">" residual link.
outflowwasn't updated with the stochasticoutflow_fractions, andAlso, this checks that net_inflow is an integer and throws an error if it is not. The other links coming into the ResidualJunctionCompartment should have integer flows when
stochastic = Truebut I'm not sure it is appropriate to check this here and throw an error?