Merged
Conversation
This shouldn't be necessary because TDC table heading do not contain the name of any populations
There is a potential edge case if the TDC name duplicates a population name. This might still be permissible elsewhere in the code. However, adding the TDC name to the reference dictionary would result in an incorrect reference if it was duplicated, but is also unnecessary because there shouldn't be any references to the TDC name
Similarly, the TDVE headings should also not match any populations, as they should instead match framework quantities. These should never be converted to references
… outside the first column
…ng logic to better align with other handling of '#ignore'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes edge cases relating to transfer and population names and databook Excel cell references