Skip to content

Marketmaker cancel bug workaround #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 1 commit into from
Aug 30, 2018
Merged

Marketmaker cancel bug workaround #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions app/renderer/swap-db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,20 @@ class SwapDB {
}

if (message.method === 'failed') {
swap.status = 'failed';
swap.progress = 1;

// TODO: Add error messages once we have errors documented
// https://github.com/atomiclabs/hyperdex/issues/180
swap.error = {
code: message.error,
message: `Error Code: ${message.error}`,
};
// This check is to ignore cancel events when the trade is no longer pending
// It's most likely caused by this mm bug
// https://github.com/jl777/SuperNET/issues/956
if (!(swap.status !== 'pending' && [-9998, -9997].includes(message.error))) {
swap.status = 'failed';
swap.progress = 1;

// TODO: Add error messages once we have errors documented
// https://github.com/atomiclabs/hyperdex/issues/180
swap.error = {
code: message.error,
message: `Error Code: ${message.error}`,
};
}
}
});

Expand Down