Preserve "Cancel" button state in the swap list#486
Merged
Conversation
Merged
We cannot keep local state as `react-virtualized` unmounts components outside the viewport: > You might be aware of this, but just to be completely clear- components will not retain state once they've left the viewport. This is a limitation of windowing with react-virtualized (or similar libraries). Any "state" that should persist should be stored externally (eg within the underlying List/Array, in Redux, in the parent component's state, etc). - bvaughn/react-virtualized#416 (comment)
sindresorhus
force-pushed
the
preserve-cancel-button-state
branch
from
4c82a20 to
8bf58dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot keep local state as
react-virtualizedunmounts components outside the viewport: