Decouple the swap modal from the swap list#494
Merged
Conversation
And instead of accepting a swap object, it now accepts a swap ID. It's the swap modal is now a controlled by the swap list instead of controlling itself.
kevva
approved these changes
Aug 31, 2018
kevva
reviewed
Aug 31, 2018
| static propTypes = { | ||
| swap: PropTypes.object, | ||
| swapId: PropTypes.string, | ||
| open: PropTypes.bool, |
Contributor
There was a problem hiding this comment.
Nitpick, but I think boolean props should be prefixed with is or has for clarity.
Contributor
Author
There was a problem hiding this comment.
I agree, but it's coming from
hyperdex/app/renderer/components/Modal.js
Line 21 in 29ca860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And instead of accepting a swap object, it now accepts a swap ID.
The swap modal is now controlled by the swap list instead of controlling itself.
This fixes the issue with an open swap modal suddenly disappearing when the swap completes, as mention in #484.
Notice how the swap list is empty, but the modal is still open: