Fix Document update conflict error#531
Merged
Merged
Conversation
Fixes #527 Fixes #528 We were not correctly updating the PouchDB documents. There is a required ceremony of updating `_rev` that we were not doing. I think the issue only first showed up now as IndexedDB either got faster or something changed internally with the Electron 3 upgrade. See: https://pouchdb.com/guides/updating-deleting.html I'm using `pouchdb-upsert` which handles some of the complications of updating a document.
Contributor
Author
|
I tested the beta and got the |
Member
|
Awesome good catch! Sorry, totally missed that, assumed |
lukechilds
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527
Fixes #528
We were not correctly updating the PouchDB documents. There is a required ceremony of updating
_revthat we were not doing. I think the issue only first showed up now as IndexedDB either got faster or something changed internally with the Electron 3 upgrade.See: https://pouchdb.com/guides/updating-deleting.html
I'm using
pouchdb-upsertwhich handles some of the complications of updating a document.